Skip to content

Charts: import the transform event names from the internal module - #35508

Merged
EugeniyKiyashko merged 1 commit into
mainfrom
typescript/viz/internal_transform_events
Oct 6, 2026
Merged

EugeniyKiyashko merged 1 commit into
mainfrom
typescript/viz/internal_transform_events

Conversation

@EugeniyKiyashko

Copy link
Copy Markdown
Contributor

No description provided.

@EugeniyKiyashko EugeniyKiyashko self-assigned this Oct 6, 2026
@EugeniyKiyashko
EugeniyKiyashko marked this pull request as ready for review October 6, 2026 12:53
@EugeniyKiyashko
EugeniyKiyashko requested a review from a team as a code owner October 6, 2026 12:53
Copilot AI balanced review requested due to automatic review settings October 6, 2026 12:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The import preserves existing event-name behavior while removing an unnecessary public-module dependency.

Review effort: Balanced
Findings: None

What changed in this PR

Updates chart zoom-and-pan code to consume transform event names directly from the internal event module.

Changes:

  • Replaces the public compatibility-module import with the internal exportNames mapping.
File Description
packages/​devextreme/​js/​__internal/​viz/​chart_components/​zoom_and_pan.ts Imports transform event names from the internal module.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@EugeniyKiyashko
EugeniyKiyashko merged commit 0ad61de into main Oct 6, 2026
150 checks passed
@EugeniyKiyashko
EugeniyKiyashko deleted the typescript/viz/internal_transform_events branch October 6, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants